-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multipart/form-data in PATCH request #536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 96.69% 96.39% -0.31%
==========================================
Files 10 10
Lines 1330 1330
==========================================
- Hits 1286 1282 -4
- Misses 26 30 +4
Partials 18 18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@jeevatkm could you please review this change. |
Seems simple enough. We obviously don't have tests around this code. Do you have time to add tests? |
@moorereason Added a simple test as per your suggestion. Please review. |
Test result.
|
@moorereason just checking in to see if you got a chance to review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabandi Thanks you for your PR and contribution. I'm sorry for the delayed attention on the PR.
@@ -128,7 +128,7 @@ func parseRequestHeader(c *Client, r *Request) error { | |||
func parseRequestBody(c *Client, r *Request) (err error) { | |||
if isPayloadSupported(r.Method, c.AllowGetMethodPayload) { | |||
// Handling Multipart | |||
if r.isMultiPart && !(r.Method == MethodPatch) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabandi HTTP spec is keep on getting better!
No description provided.