Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't it remember the window size now? #1011

Closed
moxcomic opened this issue Feb 10, 2024 · 11 comments
Closed

Why doesn't it remember the window size now? #1011

moxcomic opened this issue Feb 10, 2024 · 11 comments
Labels
bug When you are sure about it's a bug

Comments

@moxcomic
Copy link

Rod Version: v0.114.7

I remember that in previous versions, when using the same code, if you manually dragged the window to change its size, the size would be maintained the next time you started it. But now it seems to revert to a fixed size. Is it necessary now to use MustSetWindow to maintain the window size?

Code

rod.
  New().
  ControlURL(
      launcher.New().
      Headless(false).
      Bin("/Applications/Google Chrome.app/Contents/MacOS/Google Chrome").
      UserDataDir("./data").
      MustLaunch(),
  ).
  MustConnect().
  NoDefaultDevice().
  MustPage("")
@moxcomic moxcomic added the question Questions related to rod label Feb 10, 2024
Copy link

Please fix the format of your markdown:

6 MD003/heading-style/header-style Heading style [Expected: setext; Actual: atx]
6 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Code"]
7 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]
7 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

generated by check-issue

@ysmood
Copy link
Member

ysmood commented Feb 18, 2024

I haven't changed any related logic. I think every time you launch the browser, you will open a new tab, because different tabs can have the same url, how could you know it's the same one as the last launch?

@moxcomic
Copy link
Author

I haven't changed any related logic. I think every time you launch the browser, you will open a new tab, because different tabs can have the same url, how could you know it's the same one as the last launch?

I remember that in previous versions of Chrome, the browser would remember the window size changed by dragging the mouse, but after a certain update of the Chrome browser, it no longer remembers the window size. It might be due to the Chrome update.

@ysmood ysmood added the upstream Upstream issue that can't solved by Rod label Feb 18, 2024
@moxcomic
Copy link
Author

I haven't changed any related logic. I think every time you launch the browser, you will open a new tab, because different tabs can have the same url, how could you know it's the same one as the last launch?

If I don't specify UserDataDir("./data"), it can remember the window size. I don't understand the reason behind this.

@ysmood
Copy link
Member

ysmood commented Feb 22, 2024

could you try without rod? I might be a chromium issue.

@moxcomic
Copy link
Author

could you try without rod? I might be a chromium issue.

When I try launching with /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --user-data-dir=/path/to/data, it can remember the window size normally.

@ysmood
Copy link
Member

ysmood commented Feb 22, 2024

How about use the Launcher.NewUserMode

@moxcomic
Copy link
Author

How about use the Launcher.NewUserMode

It cannot record either; only when opened using the command can it normally record the window size.

@ysmood ysmood added bug When you are sure about it's a bug and removed question Questions related to rod upstream Upstream issue that can't solved by Rod labels Feb 27, 2024
@ysmood ysmood closed this as completed in c35d2ab Feb 27, 2024
@ysmood
Copy link
Member

ysmood commented Feb 27, 2024

The fix will be released in the next version

ysmood added a commit that referenced this issue Mar 6, 2024
@ysmood
Copy link
Member

ysmood commented Mar 6, 2024

Please check v0.114.8

@moxcomic
Copy link
Author

moxcomic commented Mar 7, 2024

Please check v0.114.8

Thanks, the issue has been fixed after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug When you are sure about it's a bug
Projects
None yet
Development

No branches or pull requests

2 participants