Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Page.WaitStable #870

Merged
merged 7 commits into from
May 14, 2023
Merged

Conversation

Fly-Playgroud
Copy link
Contributor

Implement this issue: #387

@Fly-Playgroud Fly-Playgroud requested a review from ysmood May 3, 2023 13:10
Copy link
Member

@ysmood ysmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add MustWaitStable helper, it uses a static d and similarity, such as 1 second and 1.

page.go Show resolved Hide resolved
page.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
2.mod unit test
@Fly-Playgroud Fly-Playgroud requested a review from ysmood May 12, 2023 13:42
page_test.go Outdated Show resolved Hide resolved
page.go Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
@Fly-Playgroud Fly-Playgroud requested a review from ysmood May 14, 2023 08:35
@ysmood ysmood enabled auto-merge (squash) May 14, 2023 09:26
@ysmood ysmood merged commit 1336c8c into go-rod:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants