Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod Page.WaitStable #883

Merged
merged 10 commits into from
May 31, 2023
Merged

mod Page.WaitStable #883

merged 10 commits into from
May 31, 2023

Conversation

Fly-Playgroud
Copy link
Contributor

remove Page.WaitLoad because it's not stable in some case

@Fly-Playgroud Fly-Playgroud requested a review from ysmood May 31, 2023 13:35
ysmood
ysmood requested changes May 31, 2023
View reviewed changes
Copy link
Member

@ysmood ysmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add utils.sleeper inside the for loop.

@Fly-Playgroud
Copy link
Contributor Author

Please add utils.sleeper inside the for loop.

Why use this? In the loop, I have used time.NewTicker.

@Fly-Playgroud
Copy link
Contributor Author

Please add utils.sleeper inside the for loop.

Why use this? In the loop, I have used time.NewTicker.

And it own the logic the same as Element.WaitStable

@Fly-Playgroud Fly-Playgroud requested a review from ysmood May 31, 2023 15:00
@ysmood ysmood merged commit bba38c2 into go-rod:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysmood ysmood ysmood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fly-Playgroud @ysmood