Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log args for root command #565

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

chain710
Copy link
Contributor

For improved debugging convenience, add some log flags in root command

  • log-level: specify log level, default info
  • log-caller: whether log file:lineno or not, default false
  • log FullTimestamp

Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chain710, sorry for the delay! This slipped through my notifications. Thank you for the improvements on the logging, much appreciated :) I have just one question before moving forward.

internal/cmd/loglevel_value.go Outdated Show resolved Hide resolved
- log-level: specify log level, default info
- log-caller: whether log `file:lineno` or not, default false
- log FullTimestamp
@fmartingr
Copy link
Member

Thank you for the contribution @chain710 !

@fmartingr fmartingr merged commit 888e59d into go-shiori:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants