Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor config fixes for internal Tegola viewer and npm package updates #794

Closed
wants to merge 4 commits into from

Conversation

mapl
Copy link

@mapl mapl commented Aug 1, 2021

No description provided.

mapl added 3 commits August 1, 2021 03:08
[Vue warn]: Invalid component name: "Tegola Viewer". Component names should conform to valid custom element name in html5 specification.
@mapl mapl requested a review from ARolek as a code owner August 1, 2021 10:20
@coveralls
Copy link

coveralls commented Aug 1, 2021

Pull Request Test Coverage Report for Build c974fb803-PR-794

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.0%

Totals Coverage Status
Change from base Build ac82d5ffc: 0.0%
Covered Lines: 5427
Relevant Lines: 12060

💛 - Coveralls

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mapl mapl requested a review from gdey as a code owner August 14, 2021 18:34
@mapl mapl force-pushed the ui-fix-and-update branch 5 times, most recently from 2dfad94 to 495d8c3 Compare August 15, 2021 08:54
@ARolek
Copy link
Member

ARolek commented Sep 7, 2021

I just merged this into v0.14.x branch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants