Allow for url encoded dbname in dsn #1388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support for dbnames containing special characters, in particular '/' which can occur in legacy rails databases (e.g. db/development or db/production)
|
Would you explain backward compatibility? |
|
Fixed in #1432. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been using this project to connect to some legacy RoR mysql databases. There is a prevalent naming convention in these databases such as 'db/development' or 'db/production'. I tried a few different approaches but couldn't figure out how to use this project with database names that contain '/' characters. In a few places in dsn.go you are using url QueryEscape and QueryUnescape, so I applied the same principal to dbname in cases where there are special characters in the dbname that break the parser.
Checklist