Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(delete event): add functionality for delete event #520

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

claire1618
Copy link
Contributor

Similar to the pull_request and push events, it would be beneficial if Vela could recognize the delete event. So the users would have the option to have Vela set off builds when a branch or tag are deleted in their repo.

The code here makes sure that users can use the CLI to update the repo to allow delete events.

Goes along with: go-vela/server#1038

@claire1618 claire1618 requested a review from a team as a code owner January 24, 2024 16:46
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (167b010) 85.68% compared to head (ec9c45d) 85.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   85.68%   85.70%   +0.01%     
==========================================
  Files         147      147              
  Lines        6476     6483       +7     
==========================================
+ Hits         5549     5556       +7     
  Misses        764      764              
  Partials      163      163              
Files Coverage Δ
action/repo/add.go 92.37% <100.00%> (+0.48%) ⬆️

@claire1618 claire1618 changed the title feat: adding functionality for a new delete event feat(delete event): add functionality for a new delete event Jan 24, 2024
@claire1618 claire1618 changed the title feat(delete event): add functionality for a new delete event feat(delete event): add functionality for delete event Jan 24, 2024
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@claire1618 claire1618 merged commit 051ca4b into main Jan 25, 2024
16 of 17 checks passed
@claire1618 claire1618 deleted the feat/deleteEvent branch January 25, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants