-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pipeline): support for API changes #161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 89.46% 89.79% +0.32%
==========================================
Files 18 18
Lines 1396 1440 +44
==========================================
+ Hits 1249 1293 +44
Misses 107 107
Partials 40 40
|
@@ -6,8 +6,8 @@ require ( | |||
github.com/buildkite/yaml v0.0.0-20181016232759-0caa5f0796e3 | |||
github.com/coreos/go-semver v0.3.0 | |||
github.com/gin-gonic/gin v1.7.7 | |||
github.com/go-vela/server v0.13.0 | |||
github.com/go-vela/types v0.13.0 | |||
github.com/go-vela/server v0.13.2-0.20220426180142-90727d2b465a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting. where is it getting v0.13.2 from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that comes from the Go module system when pulling a dependency based on a commit.
Go sees the v0.13.1
release is out there, but I'm vendoring from a commit published after that release.
So the system automatically updates to the next available patch release (v0.13.2
).
What follows after that patch is the time and date (20220426180142
).
And lastly, the shortened commit SHA that was vendored in (90727d2b465a
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐬
Dependent on go-vela/server#615
Part of the effort for go-vela/community#460
This change updates the Go SDK to support the new and updated API endpoints for
pipelines
.The new SDK functions for
pipelines
that were added with this change are:sdk-go/vela/pipeline.go
Lines 50 to 51 in 3c213f8
sdk-go/vela/pipeline.go
Lines 70 to 71 in 3c213f8
sdk-go/vela/pipeline.go
Lines 84 to 85 in 3c213f8
sdk-go/vela/pipeline.go
Lines 98 to 99 in 3c213f8
The existing SDK functions for
pipelines
were updated to acceptref
(commit SHA) as a parameter:sdk-go/vela/pipeline.go
Lines 36 to 39 in 3c213f8
sdk-go/vela/pipeline.go
Lines 112 to 115 in 3c213f8
sdk-go/vela/pipeline.go
Lines 132 to 135 in 3c213f8
sdk-go/vela/pipeline.go
Lines 152 to 155 in 3c213f8
sdk-go/vela/pipeline.go
Lines 172 to 175 in 3c213f8