Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(build): add before and after params to sdk #166

Merged
merged 1 commit into from
May 10, 2022
Merged

enhance(build): add before and after params to sdk #166

merged 1 commit into from
May 10, 2022

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 9, 2022

@ecrupper ecrupper requested a review from a team as a code owner May 9, 2022 16:24
@ecrupper ecrupper self-assigned this May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022 •
edited
Loading

Codecov Report

Merging #166 (7bebc4f) into master (514b62d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          18       18           
  Lines        1440     1440           
=======================================
  Hits         1293     1293           
  Misses        107      107           
  Partials       40       40
Impacted Files Coverage Δ
vela/build.go 96.73% <ø> (ø)

jbrockopp
jbrockopp approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wass3r
wass3r approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for additional context, the functionality in the referenced PR was released in v0.13

@wass3r wass3r merged commit 850dcdc into master May 10, 2022
@wass3r wass3r deleted the add-before-after-params branch May 10, 2022 14:06
@ecrupper ecrupper mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

@jbrockopp jbrockopp jbrockopp approved these changes

Assignees

@ecrupper ecrupper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecrupper @wass3r @cognifloyd @jbrockopp