Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deployments support #39

Merged
merged 1 commit into from
Apr 27, 2020
Merged

feat: add deployments support #39

merged 1 commit into from
Apr 27, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Apr 24, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner April 24, 2020 20:48
@jbrockopp jbrockopp self-assigned this Apr 24, 2020
@jbrockopp jbrockopp mentioned this pull request Apr 24, 2020
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #39 into master will decrease coverage by 0.12%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   91.87%   91.75%   -0.13%     
==========================================
  Files          11       12       +1     
  Lines         357      376      +19     
==========================================
+ Hits          328      345      +17     
- Misses         18       19       +1     
- Partials       11       12       +1     
Impacted Files Coverage Δ
vela/deployment.go 88.88% <88.88%> (ø)
vela/client.go 89.23% <100.00%> (+0.08%) ⬆️

Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit 5e05753 into master Apr 27, 2020
@kneal kneal deleted the feature/deployments branch April 27, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants