feat(rulesets): add support for PR labeled events #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add API changes for updating repos to leverage label events 2. Process PR label events in scm package 3. Update compiler to use label value in its purging process
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1. Update process PR event helper function 2. Update tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 61.89% 61.94% +0.05%
==========================================
Files 358 358
Lines 10885 10902 +17
==========================================
+ Hits 6737 6753 +16
- Misses 3662 3663 +1
Partials 486 486
|
ecrupper
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good. Requesting a couple extra tests. One for WithLabel(...) and one for processPREvent(...) that processes a PR payload of the labeled action type. Also it might be useful to make sure that other PR events populate the labels properly as well via a test
ecrupper
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Request for Vela to process and create builds for pull request labeled and unlabeled webhooks.
Related
GitHub issue #913
GitHub ideas #768