-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database): add engine options #886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
=======================================
Coverage ? 71.45%
=======================================
Files ? 304
Lines ? 12436
Branches ? 0
=======================================
Hits ? 8886
Misses ? 3118
Partials ? 432 |
cognifloyd
approved these changes
Jun 19, 2023
wass3rw3rk
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new
EngineOpt{}
type used to configure the database agnosticengine{}
type introduced in #868.This change also updates the
database.New()
function to accept a list ofEngineOpt{}
.Additionally, I made some miscellaneous refactors to improve consistency across the
database
package:Config{}
type ->config{}
since we no longer need it exported (a.k.a. public)engine.Logger
field ->engine.logger
since we don't need it exported (a.k.a. public)engine.Database
field ->engine.client
since we don't need it exported (a.k.a. public)