Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): add engine options #886

Merged
merged 22 commits into from
Jun 20, 2023
Merged

feat(database): add engine options #886

merged 22 commits into from
Jun 20, 2023

Conversation

jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Jun 17, 2023

This change adds a new EngineOpt{} type used to configure the database agnostic engine{} type introduced in #868.

This change also updates the database.New() function to accept a list of EngineOpt{}.

Additionally, I made some miscellaneous refactors to improve consistency across the database package:

  • updated the Config{} type -> config{} since we no longer need it exported (a.k.a. public)
  • updated the engine.Logger field -> engine.logger since we don't need it exported (a.k.a. public)
  • renamed the engine.Database field -> engine.client since we don't need it exported (a.k.a. public)

@jbrockopp jbrockopp self-assigned this Jun 17, 2023
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4e5d484). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage        ?   71.45%           
=======================================
  Files           ?      304           
  Lines           ?    12436           
  Branches        ?        0           
=======================================
  Hits            ?     8886           
  Misses          ?     3118           
  Partials        ?      432           

@jbrockopp jbrockopp marked this pull request as ready for review June 19, 2023 18:02
@jbrockopp jbrockopp requested a review from a team as a code owner June 19, 2023 18:02
@wass3rw3rk wass3rw3rk merged commit ef7d338 into main Jun 20, 2023
@wass3rw3rk wass3rw3rk deleted the feature/database/opts branch June 20, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants