Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change worker lastCheckedIn to type int64 #109

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

meinenec
Copy link
Contributor

change to make the LastCheckedIn type more similar to build's enqueued field

@meinenec meinenec requested a review from a team as a code owner September 21, 2020 22:31
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #109 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          46       46           
  Lines        2755     2757    +2     
=======================================
+ Hits         2733     2735    +2     
  Misses         12       12           
  Partials       10       10           
Impacted Files Coverage Δ
database/worker.go 100.00% <100.00%> (ø)
library/worker.go 96.07% <100.00%> (ø)

Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockopp jbrockopp merged commit 24f0a72 into master Sep 22, 2020
@jbrockopp jbrockopp deleted the update_workers branch September 22, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants