fix: issue with accidental secret exposure via wrong syntax #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 46 46
Lines 2757 2759 +2
=======================================
+ Hits 2735 2737 +2
Misses 12 12
Partials 10 10
|
wass3r
previously approved these changes
Sep 28, 2020
wass3r
reviewed
Sep 28, 2020
wass3r
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the method to inject a secret with alternative name, ie.
it's possible to expose the secret by doing the following: