fix: use tmp for empty name check #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 53 53
Lines 3270 3274 +4
=======================================
+ Hits 3169 3173 +4
Misses 56 56
Partials 45 45
|
JordanSussman
approved these changes
Jun 8, 2021
matt-fevold
approved these changes
Jun 8, 2021
wass3r
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes the following changes:
Details:
In certain, situations the compiler can call the marshaller; sometimes when this happens with templates the secrets being passed has a secret array that contains empty secret elements. This change adds extra checking in cases a secret element exists within the secrets block that doesn't have
name:.