Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(library): add deployment type #57

Merged
merged 2 commits into from
Apr 23, 2020
Merged

feat(library): add deployment type #57

merged 2 commits into from
Apr 23, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Apr 22, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner April 22, 2020 16:10
@jbrockopp jbrockopp self-assigned this Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020 •
edited
Loading

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        42    +1     
  Lines         2527      2601   +74     
=========================================
+ Hits          2527      2601   +74
Impacted Files Coverage Δ
library/deployment.go 100.00% <100.00%> (ø)

@jbrockopp jbrockopp mentioned this pull request Apr 22, 2020
Closed
KellyMerrick
KellyMerrick approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kneal
kneal approved these changes Apr 23, 2020
View reviewed changes
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit 338fccc into master Apr 23, 2020
@kneal kneal deleted the feature/library/deployment branch April 23, 2020 13:47
This was referenced Apr 23, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneal kneal kneal approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @kneal @KellyMerrick