Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(yaml): set detach for services #64

Merged
merged 3 commits into from
May 5, 2020
Merged

chore(yaml): set detach for services #64

merged 3 commits into from
May 5, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label May 5, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner May 5, 2020 13:24
@jbrockopp jbrockopp self-assigned this May 5, 2020
kneal
kneal previously approved these changes May 5, 2020
View reviewed changes
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@codecov
Copy link

codecov bot commented May 5, 2020 •
edited
Loading

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         2624      2625    +1     
=========================================
+ Hits          2624      2625    +1
Impacted Files Coverage Δ
yaml/service.go 100.00% <100.00%> (ø)

kneal
kneal approved these changes May 5, 2020
View reviewed changes
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit 3d1e3e1 into master May 5, 2020
@kneal kneal deleted the chore/yaml/service branch May 5, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @wass3r @kneal