enhancement(container): add execute function #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2625 2640 +15
=========================================
+ Hits 2625 2640 +15
|
This was referenced May 14, 2020
jbrockopp
requested changes
May 14, 2020
pipeline/container.go
Outdated
| // Execute returns true when the provided ruledata matches | ||
| // the conditions when we should be running the container on the worker. | ||
| func (c *Container) Execute(r *RuleData) bool { | ||
| // assume you will excute a container by setting flag |
There was a problem hiding this comment.
I believe this is a typo:
// assume you will excute a container by setting flag
... will execute a ...
added 2 commits
May 14, 2020 12:13
wass3r
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.