Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add json field tags to daemon #32

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

KellyMerrick
Copy link
Contributor

Add json field tags to multi-word daemon flags.

@KellyMerrick KellyMerrick added the bug Indicates a bug label Apr 6, 2021
@KellyMerrick KellyMerrick requested a review from a team as a code owner April 6, 2021 16:56
@KellyMerrick KellyMerrick self-assigned this Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #32 (1294a87) into master (21381d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   51.79%   51.79%           
=======================================
  Files           7        7           
  Lines         363      363           
=======================================
  Hits          188      188           
  Misses        167      167           
  Partials        8        8           
Impacted Files Coverage Δ
cmd/vela-docker/daemon.go 63.82% <ø> (ø)

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KellyMerrick KellyMerrick merged commit fdce13b into master Apr 6, 2021
@KellyMerrick KellyMerrick deleted the fix/daemonflags branch April 6, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants