feat: parse credential bytes #258
Conversation
This adds methods to parse raw byte slices instead of an io.Reader via protocol.ParseCredentialCreationResponseBytes and protocol.ParseCredentialRequestResponseBytes.
WalkthroughThe recent changes introduce new functions for parsing credential request and creation responses directly from byte slices, enhancing flexibility and usability. A new utility function, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
protocol/decoder.go (1)
26-39: Consider improving the error message for clarity.The error message "The body contains trailing data" is the same as in
decodeBody. To differentiate, consider specifying that the data is from a byte slice.- return errors.New("The body contains trailing data") + return errors.New("The byte slice contains trailing data")protocol/assertion.go (1)
78-86: Consider improving the error message for clarity.The error message "Parse error for Assertion" is the same as in
ParseCredentialRequestResponseBody. To differentiate, consider specifying that the data is from a byte slice.- return nil, ErrBadRequest.WithDetails("Parse error for Assertion").WithInfo(err.Error()) + return nil, ErrBadRequest.WithDetails("Parse error for Assertion from byte slice").WithInfo(err.Error())protocol/credential.go (1)
90-98: Consider improving the error message for clarity.The error message "Parse error for Registration" is the same as in
ParseCredentialCreationResponseBody. To differentiate, consider specifying that the data is from a byte slice.- return nil, ErrBadRequest.WithDetails("Parse error for Registration").WithInfo(err.Error()) + return nil, ErrBadRequest.WithDetails("Parse error for Registration from byte slice").WithInfo(err.Error())
This adds methods to parse raw byte slices instead of an io.Reader via protocol.ParseCredentialCreationResponseBytes and protocol.ParseCredentialRequestResponseBytes.