Add support for strict boolean parsing (Was #214) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinzenz What is the latest on this PR? Is it up to date with the latest commits? Is it ready to be merged if we can get it reviewed? |
added 6 commits
September 20, 2017 10:02
Signed-off-by: Vinzenz Feenstra <evilissmo@redhat.com>
…problems Signed-off-by: Vinzenz Feenstra <evilissmo@redhat.com>
Signed-off-by: Vinzenz Feenstra <evilissmo@redhat.com>
Signed-off-by: Vinzenz Feenstra <evilissmo@redhat.com>
vinzenz
force-pushed
the
fix-for-issue-214
branch
from
b373073
to
759b7ad
Compare
vinzenz
changed the title
|
Version 1.2 of the spec constrains booleans to only true and false indeed, and that's the default behavior we'll have in v3, which is going to be out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with kubernetes/kubernetes#34146
by introducing a new option to restrict the booleans to only
trueandfalse