Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix match race condition with vars map #40

Merged
merged 1 commit into from
Mar 4, 2016
Merged

fix match race condition with vars map #40

merged 1 commit into from
Mar 4, 2016

Conversation

hexadecy
Copy link
Contributor

@hexadecy hexadecy commented Mar 4, 2016

Since Go 1.6 race condition is better detected.

fatal error: concurrent map read and map write
fatal error: concurrent map read and map write

goroutine 10105 [running]:
runtime.throw(0xa6a2c0, 0x21)
C:/Go/src/runtime/panic.go:530 +0x97 fp=0xc0820639c8 sp=0xc0820639b0
runtime.mapaccess1_fast64(0x86ed40, 0xc082052c90, 0xc082126540, 0x1)
C:/Go/src/runtime/hashmap_fast.go:112 +0x61 fp=0xc0820639e8 sp=0xc0820639c8
local/beenote/vendor/github.com/go-zoo/bone.(_Route).Match(0xc08214c500, 0xc082126540, 0x9e6700)
C:/Workspace/src/local/beenote/vendor/github.com/go-zoo/bone/route.go:98 +0x121 fp=0xc082063b58 sp=0xc0820639e8
local/beenote/vendor/github.com/go-zoo/bone.(_Route).parse(0xc08214c500, 0x2a44338, 0xc082122060, 0xc082126540, 0xc082049100)
C:/Workspace/src/local/beenote/vendor/github.com/go-zoo/bone/route.go:133 +0x196 fp=0xc082063bc0 sp=0xc082063b58

@squiidz
Copy link
Member

squiidz commented Mar 4, 2016

Merci ;)

squiidz pushed a commit that referenced this pull request Mar 4, 2016
fix match race condition with vars map
@squiidz squiidz merged commit c5bdf6d into go-zoo:master Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants