go 1.7 context #54
go 1.7 context #54
Conversation
This also addresses a bug where using net.Context causes bone to silently fail due to http.Request.WithContext not preserving pointer identity.
skabbes
force-pushed
the
feature/go_17_context
branch
5 times, most recently
from
a69b9d1
to
4600a3c
Compare
skabbes
force-pushed
the
feature/go_17_context
branch
from
4600a3c
to
ff1722f
Compare
| } | ||
|
|
||
| vars := make(map[string]string, totalSize) |
There was a problem hiding this comment.
Instead of letting the map dynamically re-allocate when we need it to. I am pre-counting the space that will be needed and allocating exactly that amount of space.
|
Awesome work ! Probably the best PR i've ever get !! For the breaking changes in your code, i don't mind if it's not a major one, maybe just indicate it in the changelog would be enough. |
|
Ok, I actually changed it to have no breaking changes. I think as a developer, this is what I would have wanted when upgrading. Would love to get this merged so I can start using bone + net.Context very soon !! |
|
Are you interested to become a bone maintainer ? |
|
Hey @squiidz I don't know how much time I can dedicate to it, but I know the code and use cases well enough that I can help out when I can. Do you have a roadmap of things you want to add? |
Refactor value storage to use net.Context. This allows users of bone to use
http.Request.WithContextwithout bone breaking.I also expect this to have performance benefits since the map of requests has been completely eliminated (and locking is no longer required, since we don't allow mutations of the request values).