Make dialer extensible by making it an interface #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbeza
force-pushed
the
generic-dialer
branch
from
539ffb0
to
5acb711
Compare
pawelbeza
force-pushed
the
generic-dialer
branch
from
5acb711
to
3f7b1b3
Compare
|
This is a breaking change and moves away from the function signature in the ‘net’ package. You should be able to handle this with a closure or even pass a method in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, could we make dialer an interface so that we could make it more extensible?
To give you an example why it would be a great feature ...
In our case we'd like to add exponential backoff if zookeeper is not reachable. Currently it's not possible to implement as that would require keeping some state inside dialer. Since dialer is currently a function it's not possible to do that.
That's why it would be awesome to make dialer an interface instead and make it more extensible this way :)