fix: Allow abstract.com domain for share links and expose inferShareId (

#217) * Allow abstract.com domain for share links and expose inferShareId * Add test for new domain check
goabstract · Feb 16, 2020 · 7789a92 · 7789a92
1 parent a000ca6
commit 7789a92
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -1,6 +1,7 @@
 // @flow
 /* istanbul ignore file */
 import Client from "./Client";
+import { inferShareId } from "./util/helpers";
 import { paginate } from "./paginate";
 import * as sketch from "./sketch";
 import {
@@ -31,6 +32,7 @@ export {
   ServiceUnavailableError,
   UnauthorizedError,
   // Utilities
+  inferShareId,
   paginate,
   sketch
 };

diff --git a/src/util/helpers.js b/src/util/helpers.js
@@ -2,7 +2,7 @@
 import type { ShareDescriptor } from "../types";
 
 function parseShareURL(url: string): ?string {
-  return url.split("share.goabstract.com/")[1];
+  return url.split(/share\.(?:go)?abstract\.com\//)[1];
 }
 
 export function inferShareId(shareDescriptor: ShareDescriptor): string {

diff --git a/tests/util/helpers.test.js b/tests/util/helpers.test.js
@@ -9,6 +9,11 @@ describe("helpers", () => {
         url: "share.goabstract.com/share-id"
       })
     ).toBe("share-id");
+    expect(
+      utils.inferShareId({
+        url: "share.abstract.com/share-id-2"
+      })
+    ).toBe("share-id-2");
   });
 
   test("inferShareId throws", () => {