TTFB swapped with overall request Elapsed Time

[zeph]

the overall elapsed time shall be associated to the 4th int64 time measurement as by this structure

type RequestResult struct {
	Time             int64  `json:"time"`
	Host             string `json:"host"`
	Type             string `json:"type"`
	Status           int    `json:"status"`
	ElapsedFirstByte int64  `json:"elapsed-first-byte"`
	ElapsedLastByte  int64  `json:"elapsed-last-byte"`
	Elapsed          int64  `json:"elapsed"`
	Bytes            int    `json:"bytes"`
	Timeout          bool   `json:"timeout"`
	ConnectionError  bool   `json:"connection-error"`
	State            string `json:"state"`
}

[jcxplorer]

Whoops, I guess we should use named fields to prevent these bugs. Would you like to add those before I merge? 🙂

[zeph]

@jcxplorer I don't know named fields yet, these hacks are my learning by writing golang experience ;) ...I'll have a look at them if you think they are the best way to implement them

[jcxplorer]

What I meant is that you can use the field names explicitly, like so:

result := RequestResult{
    Time: start.Sub(loadTestStartTime).Nanoseconds(),
    Host: req.URL.Host,
    Type: req.Method,

That way the order doesn't matter, which would have prevented this bug 🙂

[zeph]

@jcxplorer done, please have a look

[jcxplorer]

Brilliant, thanks for this!

[zeph]

@jcxplorer you are welcome