Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP and gRPC log middleware/interceptor #283

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

raphael
Copy link
Member

@raphael raphael commented Sep 6, 2023

So they log each request and response status.

This replaces the use of the Goa HTTP middleware and adds logs for gRPC.

This PR also switches to golangci-lint for linting.

log each request and response status.

This replaces the use of the Goa HTTP middleware and adds logs for gRPC.

This PR also switches to golangci-lint for linting.
@codecov-commenter
Copy link

Codecov Report

Merging #283 (b47e376) into main (4d1dc69) will increase coverage by 0.02%.
The diff coverage is 95.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   94.42%   94.45%   +0.02%     
==========================================
  Files          43       43              
  Lines        2225     2309      +84     
==========================================
+ Hits         2101     2181      +80     
- Misses         91       94       +3     
- Partials       33       34       +1     
Flag Coverage Δ
micro 94.45% <95.27%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
trace/options.go 73.46% <85.71%> (ø)
log/http.go 84.61% <88.23%> (+1.05%) ⬆️
log/grpc.go 94.73% <98.64%> (+2.81%) ⬆️
debug/debug.go 100.00% <100.00%> (ø)
debug/grpc.go 100.00% <100.00%> (ø)
debug/options.go 100.00% <100.00%> (ø)
health/handler.go 100.00% <100.00%> (ø)
log/format.go 100.00% <100.00%> (ø)
log/log.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael raphael merged commit a9e5165 into main Sep 6, 2023
1 check passed
@raphael raphael deleted the log_requests branch September 6, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants