Fix test helper panic when controller does not write media type (#719)

goadesign · Aug 9, 2016 · 72202fd · 72202fd
1 parent 2a6e833
commit 72202fd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/design/types.go b/design/types.go
@@ -665,7 +665,7 @@ func (u *UserTypeDefinition) ToHash() *Hash { return u.Type.ToHash() }
 // CanHaveDefault calls CanHaveDefault on the user type underlying data type.
 func (u *UserTypeDefinition) CanHaveDefault() bool { return u.Type.CanHaveDefault() }
 
-// IsCompatible returns true if val is compatible with p.
+// IsCompatible returns true if val is compatible with u.
 func (u *UserTypeDefinition) IsCompatible(val interface{}) bool {
 	return u.Type == nil || u.Type.IsCompatible(val)
 }

diff --git a/goagen/gen_app/test_generator.go b/goagen/gen_app/test_generator.go
@@ -361,6 +361,9 @@ func {{ $test.Name }}(t *testing.T, ctx context.Context, service *goa.Service, c
 		if !ok {
 			t.Errorf("invalid response media: got %+v, expected instance of {{ $test.ReturnType.Type }}", resp)
 		}
+		if mt == nil {
+			t.Errorf("nil response media type, expected instance of {{ $test.ReturnType.Type }}")
+		}
 {{ if $test.ReturnType.Validatable }}		err = mt.Validate()
 		if err != nil {
 			t.Errorf("invalid response media type: %s", err)