Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign to default param values. #1024

Merged
merged 1 commit into from Feb 3, 2017
Merged

Assign to default param values. #1024

merged 1 commit into from Feb 3, 2017

Conversation

@brycereitano
Copy link
Contributor

@brycereitano brycereitano commented Feb 1, 2017

This would close #754 (already closed) and half finish #658. I may set some time aside to cherry pick the changes for headers as well. I want to get this PR finalized and merged before that.

I made codegen.printVals public for use of printing the literal default values.
I added a lot of tests to make sure it was being handled properly everywhere. I may have gone a bit overboard.

@raphael
Copy link
Member

@raphael raphael commented Feb 3, 2017

This is awesome, thank you!

@raphael raphael merged commit ccaff43 into goadesign:v1 Feb 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants