Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMO-1294 xray: request-level segment shouldn't be marked "subsegment" #1350

Merged
merged 1 commit into from Aug 9, 2017

Conversation

@jim-slattery-rs
Copy link
Contributor

@jim-slattery-rs jim-slattery-rs commented Aug 9, 2017

This was causing an X-Ray trace through multiple services to show up as a tree of subsegments under a single service. So queries like service("xyz") wouldn't show anything, even though the trace did flow through that service.

@jim-slattery-rs jim-slattery-rs force-pushed the DMO-1294_tracing_fixup branch from 36e3e35 to b8d738f Aug 9, 2017
@raphael
Copy link
Member

@raphael raphael commented Aug 9, 2017

Thank you!

Loading

@raphael raphael merged commit 3899ac9 into goadesign:v1 Aug 9, 2017
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants