Support server reflection service on gRPC server #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! thank you. Do you think it would be useful to add a comment on top of the line that calls |
|
That markdown seems to be hosted on https://grpc.github.io/grpc/core/md_doc_server-reflection.html. I added it as a comment. |
|
Looks great, just update the test to reflect the comment and I'll merge - thank you! |
|
Woops, I fixed it! |
tchssk
added a commit
to tchssk/goa
that referenced
this pull request
Dec 12, 2019
* Support server reflection service on gRPC server * Add a comment * Fix tests
raphael
pushed a commit
that referenced
this pull request
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a support of server reflection service to the generated example gRPC server.