Generate view types for embedded user types #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit was too aggressive and removed user types that are used by result types. These user types need corresponding types in the views package so that result types can be projected. This commit changes the check to be at the root of the type: if a type has no result type attribute recursively then it does not need to have corresponding view types. If a type contains result types then the type and all user type it uses are projected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit was too aggressive and removed user types that are used by result types. These user types need corresponding types in the views package so that result types can be projected. This commit changes the check to be at the root of the type: if a type has no result type attribute recursively then it does not need to have corresponding view types. If a type contains result types then the type and all user type it uses are projected.