New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential duplicate generation of payload types. #681

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
1 participant
@raphael
Copy link
Member

raphael commented Aug 3, 2016

This commit does two things:

  1. It makes sure that action definitions that refer to user types to
    define the payload only duplicates the definition if needed (i.e. if
    the payload definition overrides some of the type attributes).
  2. It makes sure that a payload type is only generated if there is not
    a user type with the same type name.
Fix potential duplicate generation of payload types.
This commit does two things:

1. It makes sure that action definitions that refer to user types to
   define the payload only duplicates the definition if needed (i.e. if
   the payload definition overrides some of the type attributes).

2. It makes sure that a payload type is only generated if there is not
   a user type with the same type name.

@raphael raphael force-pushed the fix_duplicate_payload_types branch from 95a7fcf to f622f61 Aug 3, 2016

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Aug 3, 2016

Fix #677

@raphael raphael merged commit 35d91a4 into master Aug 3, 2016

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@raphael raphael deleted the fix_duplicate_payload_types branch Aug 3, 2016

@raphael raphael restored the fix_duplicate_payload_types branch Aug 3, 2016

@raphael raphael deleted the fix_duplicate_payload_types branch Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment