Fix length validations to count the length of the string using by utf8.RuneCountInString(). #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thank you! Do you think you could add a test as well? Thanks! |
|
Thanks! I will try to add some test. |
ikawaha
changed the title
ikawaha
changed the title
|
Great, thank you! |
ikawaha
added a commit
to ikawaha/goa
that referenced
this pull request
Dec 13, 2016
…8.RuneCountInString(). (goadesign#740) * Fix length validations to count the length of the string using by utf8.RuneCountInString(). * Add SimpleImport to MediaType and UserMediaType. * Fix generation codes of InvalidLengthError * Add a length validation test for string type
raphael
pushed a commit
that referenced
this pull request
Dec 13, 2016
…i-byte UTF-8 characters. (#962) * Fix length validations to count the length of the string using by utf8.RuneCountInString(). (#740) * Fix length validations to count the length of the string using by utf8.RuneCountInString(). * Add SimpleImport to MediaType and UserMediaType. * Fix generation codes of InvalidLengthError * Add a length validation test for string type * Use att.Type.Kind() == design.StringKind instead of att.Type.Name() == "string"
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #739