Support swagger extensions #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael
reviewed
Sep 16, 2016
| } | ||
|
|
||
| _Info Info |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| return merged, nil | ||
| } | ||
|
|
||
| func (i Info) MarshalJSON() ([]byte, error) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
tchssk
force-pushed
the
swagger-extensions
branch
from
17b6142
to
4f91870
Compare
|
Oops, I added the comments but travis tells me another error... |
|
Pro tip: run |
|
Thanks. I forget to |
tchssk
force-pushed
the
swagger-extensions
branch
from
1f4526a
to
41eddae
Compare
|
Looks great, thank you for the awesome PR! Is it ready for merge? (LGTM) |
tchssk
force-pushed
the
swagger-extensions
branch
from
ba57024
to
9b6a2bb
Compare
|
Thank you for your waiting. It is ready. |
|
Do you think you could also send a PR against the v1 branch? this is a backwards compatible change and it would be great if people on the v1 branch could benefit from it too :) |
|
It's OK. But this PR is based on #775 so I will send that to v1 first. |
|
Perfect, thanks again! |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends
apidsl.Metadata()to support Swagger Extensions.Now it includes only core implementations so I will add tests and comments for godoc.
https://gophers.slack.com/archives/goa/p1473747445000640