-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unix domain socket listener to service.ListenAndServeUnix #837
Conversation
Thanks for the PR! goa has to compile / run on Windows and in App Engine (package syscall cannot be used there). Also it seems a bit strange to handle signals only when listening on a Unix socket. Given all this and how it's simple to do this in your own code I'm not sure this is worth adding to goa. Is there a reason you cannot have that code outside? Maybe this should be an example instead. |
This reverts commit 33f8e6e.
Sorry, I was not able to consider multiple environments. I will take you another approach that inject listener to function like net.http.Serve. |
This approach seems much better indeed, thank you! Just one nitpick: do you think you could change the comment of the method to something like: // Serve accepts incoming HTTP connections on the listener l, invoking the service mux handler for each. Thank you! |
1e95490
to
75f92f6
Compare
I fixed it. |
This is great thank you! Do you think you could also make a PR against the |
I made a p-r #838 . |
Hi.
I very often use unix domain socket listener with HTTP proxy server. (e.g, Nginx)
In goa, it looks no way to use that.
This p-r add function
service.ListenAndServeUnix
that support unix domain socket listener.Can you review this?
Thank you.