New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress diffs of generated codes on GitHub #953

Merged
merged 1 commit into from Dec 7, 2016

Conversation

Projects
None yet
2 participants
@tchssk
Copy link
Member

tchssk commented Dec 7, 2016

This pull request makes goagen compatible to diff suppression of Linguist.

https://github.com/github/linguist/blob/master/lib/linguist/generated.rb#L44-L81
https://github.com/github/linguist/blob/master/lib/linguist/generated.rb#L258-L263

Generated app codes by goagen will be suppressed in diffs on GitHub.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Dec 7, 2016

This is great! thank you. Do you think you could backport this to the v1 branch as well?

@raphael raphael merged commit 3ec4c6c into goadesign:master Dec 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raphael

This comment has been minimized.

Copy link
Member

raphael commented Apr 12, 2017

ugh I broke this with #1160 - will fix.

@tchssk

This comment has been minimized.

Copy link
Member

tchssk commented Apr 13, 2017

Oh thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment