Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3378480 by nkoporec: Add tests for #3378480 #3483

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

nkoporec
Copy link
Contributor

Problem

We merged #3472 without writing tests for it, so we need to add them.

Solution

Add behat tests for #3472.

Issue tracker

https://www.drupal.org/project/social/issues/3378480

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  • Run entire test suite and make sure it passes.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Add tests for #3472

Change Record

Translations

@nkoporec nkoporec added status: needs review This pull request is waiting for a requested review prio: medium type: test Adds or improves test coverage without other changes team: guardians needs: behat review labels Aug 17, 2023
@nkoporec nkoporec added this to the 11.9.10 milestone Aug 17, 2023
@mergeable
Copy link

mergeable bot commented Aug 17, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@tbsiqueira tbsiqueira merged commit 03299da into main Aug 17, 2023
190 checks passed
@tbsiqueira tbsiqueira deleted the issue/3378480/reply-to-comment-missing-tests branch August 17, 2023 14:12
@tbsiqueira tbsiqueira removed this from the 11.9.10 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: test Adds or improves test coverage without other changes
Development

Successfully merging this pull request may close these issues.

2 participants