Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3398750 by nkoporec: Can't select a group when creating a content list block and using the event content type #3592

Conversation

nkoporec
Copy link
Contributor

@nkoporec nkoporec commented Nov 2, 2023

Problem

I'm creating a new content list block using the layout builder. I want to select an "event content type" and also limit these event to a specific group. When trying to search for my group it never shows up in the autocomplete options.

Solution

The issue is that the flexible group type is not set as an option to be referenced for this field, so we need to add it.

Issue tracker

https://www.drupal.org/project/social/issues/3398750

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  1. Enable social_event_content_block module.
  2. Create a new flexible group
  3. Create a new event that is part of the group created before
  4. Go to block/add and select the Custom content list block
  5. Select the 'Event' as Type of Content
  6. In the "Groups" field try to search for the group created before
  7. Group can't be found.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Fixed an issue with custom content list block form, where users could not reference a flexible groups.

Change Record

Translations

@nkoporec nkoporec added status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Nov 2, 2023
@nkoporec nkoporec added this to the 12.0.0-rc4 milestone Nov 2, 2023
Copy link

mergeable bot commented Nov 2, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@nkoporec nkoporec added the type: bug Fixes a bug in Open Social label Nov 2, 2023
@nkoporec nkoporec marked this pull request as ready for review November 2, 2023 15:02
@BiaInacio
Copy link
Contributor

Group related to the event is an option as expected!
image

Copy link
Contributor

@vcsvinicius vcsvinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this PR

@robertragas robertragas force-pushed the bug/issue/3398750/cant-select-flexible-group-in-custom-content-list-block branch from e3e805f to e48037c Compare November 17, 2023 11:40
@robertragas robertragas merged commit 6ad6a66 into main Nov 17, 2023
186 checks passed
@robertragas robertragas deleted the bug/issue/3398750/cant-select-flexible-group-in-custom-content-list-block branch November 17, 2023 12:24
@robertragas
Copy link
Contributor

Merged and cherry-picked to 12.0.x

@robertragas robertragas added backport: verified This pull request has been back ported to an older minor version status: no action needed and removed status: needs review This pull request is waiting for a requested review labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium team: guardians type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

5 participants