Issue #3407056 by nkoporec: Error: Call to a member function get() on null Drupal\\social_activity\\EmailTokenServices->getUserPreview()

[nkoporec]

Problem

When expecting logs we found the following error, popping up multiple times:

Error: Call to a member function get() on null Drupal\social_activity\EmailTokenServices->getUserPreview() (line 251 of /app/html/profiles/contrib/social/modules/social_features/social_activity/src/EmailTokenServices.php)

Solution

Make sure that the field exists before calling get()

Issue tracker

https://www.drupal.org/project/social/issues/3407056

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

• Install Open Social
• Create a group and add group members
• Send an email to group members and use a token in the email

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Fixed an undefined error that occurred when sending out emails with tokens.

Change Record

Translations

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[vcsvinicius]

@nkoporec I add an assignment

[nkoporec]

@vcsvinicius this is ready for re-review

[vcsvinicius]

@nkoporec I approved the PR

[ronaldtebrake]

Also cherry-picked to 12.1.x and 12.0.x