Issue #3445409: Remove expensive entity loads for the event enrollments counter #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramtenhove
added
team: enterprise
ronaldtebrake
approved these changes
May 6, 2024
…event enrollment counter
bramtenhove
force-pushed
the
issue/event-enrollments-count-only
branch
from
2e7fc8d
to
c12e19a
Compare
ronaldtebrake
added
the
backport: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The event page has an enrollments block with a counter of how many people enrolled. This counter is loading event enrollment entities which is unnecessary.
When there are a lot of enrolments to an event the page becomes unnecessarily slow.
Solution
Add a simple flag loading just the IDs. This way implementations from others will not be affected.
Issue tracker
https://www.drupal.org/project/social/issues/3445409
Theme issue tracker
N/a
How to test
Screenshots
N/a
Release notes
The counter showing how many people were joining an event was loading an unnecessary amount of data. It now loads only what it needs.
Change Record
N/a
Translations
N/a