Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3455886: Add improvements to the preview element view #3941

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Agamich-FE
Copy link
Collaborator

@Agamich-FE Agamich-FE commented Jun 20, 2024

Problem

The user name has an incorrect view on the Like popup.
The page can not scroll when the preview popup is opened.

Solution

Remove the overflow: hidden styles when opening the preview popup.
Reset the default preview element styles for the user name on the Like popup.

Issue tracker

Theme issue tracker

How to test

  • Go to the Home page
  • Hover any user profile picture in comments on the post
  • Let the preview popup teaser appear(or click on the likes on the post)
  • Try scrolling up or down using the mouse or trackpad to scroll

Screenshots

Screenshot 2024-06-20 at 12 41 04
Screenshot 2024-06-20 at 12 41 15

Release notes

Add improvements to the preview element view.
Reset the default preview element styles for the user name on the Like popup.

Change Record

Translations

@Agamich-FE Agamich-FE added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review prio: high labels Jun 20, 2024
@Agamich-FE Agamich-FE added this to the 12.3.6 milestone Jun 20, 2024
@Agamich-FE Agamich-FE requested a review from ribel June 20, 2024 09:44
@Agamich-FE Agamich-FE self-assigned this Jun 20, 2024
@ribel ribel modified the milestones: 12.3.6, 13.0.0-alpha6 Jun 20, 2024
@Agamich-FE Agamich-FE force-pushed the bugfix/3455886-preview-popup-issue branch from 52357d2 to 3f81cee Compare June 21, 2024 07:49
@Agamich-FE Agamich-FE force-pushed the bugfix/3455886-preview-popup-issue branch from 3f81cee to 63e327b Compare June 21, 2024 09:09
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were tested and works as expected.

@ribel ribel merged commit edd59b2 into main Jun 25, 2024
188 checks passed
@ribel ribel deleted the bugfix/3455886-preview-popup-issue branch June 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

2 participants