Enable AppVeyor integration for Windows tests #378
Conversation
|
@TheCelavi Looks like we have issues on Windows platform :) Some commands could not be executed in tests. See PR details for appveyor... And another part of errors is related to Win-slashes... |
|
Looks like test results can be uploaded in jUnit format to AppVeyor appveyor/ci#92 (comment) Need to add this as well. |
lisachenko
force-pushed
the
feature/app-veyor-integration
branch
from
4c634b9
to
b0647d0
Compare
|
Ok, got it. Hate Windows! Will setup an env and fix those... |
| @@ -114,16 +115,17 @@ protected function loadConfiguration() | |||
| */ | |||
| protected function execute($command, $args = null, $expectSuccess = true, $expectedExitCode = null) | |||
| { | |||
| $commandStatement = sprintf('GO_AOP_CONFIGURATION=%s php %s %s %s %s', | |||
| $this->getConfigurationName(), | |||
| $phpExecutable = (New PhpExecutableFinder())->find(); | |||
There was a problem hiding this comment.
PHP keywords must be lowercase; expected new but found New
| $commandStatement = sprintf('GO_AOP_CONFIGURATION=%s php %s %s %s %s', | ||
| $this->getConfigurationName(), | ||
| $phpExecutable = (New PhpExecutableFinder())->find(); | ||
| $commandStatement = sprintf('%s %s %s %s %s', |
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
lisachenko
force-pushed
the
feature/app-veyor-integration
branch
from
93a24f4
to
c0b302d
Compare
|
Oh, crap... Errors are present because Windows has a 260 symbols length limit for filenames and couldn't delete file for annotation that 260+ symbols long. |
| $commandStatement = sprintf('GO_AOP_CONFIGURATION=%s php %s %s %s %s', | ||
| $this->getConfigurationName(), | ||
| $phpExecutable = (new PhpExecutableFinder())->find(); | ||
| $commandStatement = sprintf('%s %s %s %s %s', |
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
|
The inspection completed: No new issues |
|
✅ Build framework 2.x.21 completed (commit d8de967d18 by @lisachenko) |
|
Woot! It's working :) Not ideal, but it's good start point for now. |
It would be nice to run tests on Windows platform too to prevent errors on Windows platform