Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file #85

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Add LICENSE file #85

merged 1 commit into from
Oct 27, 2017

Conversation

siwinski
Copy link
Contributor

No description provided.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

Copy link

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template is valid, but I'm not sure if:

  1. the years are correct
  2. licensing should happen to specific person (Alexander Lisachenko) or organization (Go! Aspect-Oriented Framework)

@lisachenko lisachenko merged commit 31bd6b5 into goaop:master Oct 27, 2017
@lisachenko
Copy link
Member

Merged, thanks!

@lisachenko lisachenko added this to the 1.4.1 milestone Oct 27, 2017
@siwinski
Copy link
Contributor Author

Even though this has been merged, I wanted to provide details about @aik099 's concerns above:

the years are correct

I just took the year of the first commit in this repo until now

licensing should happen to specific person (Alexander Lisachenko) or organization (Go! Aspect-Oriented Framework)

I just took the "authors" value from the composer.json file

@lisachenko
Copy link
Member

I just took the year of the first commit in this repo until now

This year is correct one :)

licensing should happen to specific person (Alexander Lisachenko) or organization (Go! Aspect-Oriented Framework)
I just took the "authors" value from the composer.json file

I think it will be more correct to license library to all contributors of parser-reflection. However, I don't mind licensing it to me :)

@loren-osborn
Copy link
Contributor

👍

I suppose you could always add et al to @lisachenko's name. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants