AddonLifecycle ReceiveEvent improvements #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to make sure addons that invoke virtual functions for other addons don't trigger lifecycle messages multiple times.
Disable hook when all listeners for an addon unregister
KazWolfe
approved these changes
Oct 31, 2023
wozaiha
pushed a commit
to ottercorp/Dalamud
that referenced
this pull request
Dec 8, 2023
* Prototype * Add hook null safety Add a check to make sure addons that invoke virtual functions for other addons don't trigger lifecycle messages multiple times. * Expose event listeners for AddonLifecycleWidget.cs Disable hook when all listeners for an addon unregister * Add AddonLifecycleWidget.cs * Remove excess logging IME fix AddonLifecycle ReceiveEvent improvements (goatcorp#1511) * Prototype * Add hook null safety Add a check to make sure addons that invoke virtual functions for other addons don't trigger lifecycle messages multiple times. * Expose event listeners for AddonLifecycleWidget.cs Disable hook when all listeners for an addon unregister * Add AddonLifecycleWidget.cs * Remove excess logging Add Additional AddonSetup (goatcorp#1460) * Add Additional AddonSetup * Update Documentation AddonLifecycle Add AddonReceiveEvent (goatcorp#1473) AddonLifecycle Extra Safety (goatcorp#1483) * Disallow attempting to hook base AtkEventListener.ReceiveEvent * Fix incorrect address resolution * Add exception guards * Remove debug logging Fix multi-line copy/paste between ImGui and XIV (goatcorp#1525) w Prevent Tab key from breaking input fix minor things Make CJK imes work better Miscellaneous improvements (goatcorp#1537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new subsystem groups together the ReceiveEvent hooks for multiple addons when they share the same ReceiveEvent handler.
This addresses the issue that occurs when you try to hook addons that share handlers causing them to invoke each-others handlers recursively resulting in a stack overflow crash.
Also adds
AddonLifecycleData Window Widget for viewing the current status of all listeners and receive event handlersCloses #1508