Quote source paths in reload_config keybinding #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use macOS and installed nushell via brew. It installs configs in a path that contains a space (blurgh), so when I tried your `reload_config` keybinding as is, it fails. Per the [discussion on discord](https://discord.com/channels/601130461678272522/1093381138434764861/1093381138434764861), I tested surrounding the paths being fed to the source commands with "", then '', and while either of those work on a mac, someone mentioned that only '' works on Windows, so I added '' around the path expansions to handle the case where those paths might contain a space.
amtoine
approved these changes
Apr 8, 2023
|
thanks @RickCogley |
|
My pleasure :)
…________________________________
From: Antoine Stevan ***@***.***>
Sent: Saturday, April 8, 2023 6:10 PM
To: goatfiles/dotfiles ***@***.***>
Cc: Rick Cogley ***@***.***>; Mention ***@***.***>
Subject: Re: [goatfiles/dotfiles] Quote source paths in reload_config keybinding (PR #86)
thanks @RickCogley<https://github.com/RickCogley>
—
Reply to this email directly, view it on GitHub<#86 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAD5CSEIHW3AV5OURXXUDCDXAETPPANCNFSM6AAAAAAWWAVQZE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use macOS and installed nushell via brew. It installs configs in a path that contains a space (blurgh), so when I tried your
reload_configkeybinding as is, it fails. Per the discussion on discord, I tested surrounding the paths being fed to the source commands with "", then '', and while either of those work on a mac, someone mentioned that only '' works on Windows, so I added '' around the path expansions to handle the case where those paths might contain a space.