Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: ensure scim group member isn't None #5391

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 27, 2023

closes #5385

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.03 ⚠️

Comparison is base (b058906) 92.39% compared to head (21e86ff) 92.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5391      +/-   ##
==========================================
- Coverage   92.39%   92.35%   -0.03%     
==========================================
  Files         506      506              
  Lines       25913    25917       +4     
==========================================
- Hits        23939    23934       -5     
- Misses       1974     1983       +9     
Flag Coverage Δ
e2e 51.70% <20.00%> (-0.02%) ⬇️
integration 26.29% <20.00%> (-0.04%) ⬇️
unit 89.53% <60.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/providers/scim/clients/group.py 77.78% <50.00%> (-0.38%) ⬇️
authentik/lib/sentry.py 92.96% <100.00%> (+0.11%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 7b0d8f8 into main Apr 27, 2023
@BeryJu BeryJu deleted the providers/scim/default-group-members branch April 27, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When group added, SCIM throws error trying to append to Optional list field
1 participant