stages/authenticator_validate: fix regression

[BeryJu]

Details

resolves #6061

Regression added in 2023.4.2 and 2023.5.4, adds tests to prevent this regression in the future

Changes

New Features

• Adds feature which does x, y, and z.

Breaking Changes

• Adds breaking change which causes <issue>.

Checklist

• Local tests pass (ak test authentik/)
• The code has been formatted (make lint-fix)

If an API change has been made

• The API schema has been updated (make gen-build)

If changes to the frontend have been made

• The code has been formatted (make web)
• The translation files have been updated (make i18n-extract)

If applicable

• The documentation has been updated
• The documentation has been formatted (make website)

[netlify]

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	22f27e4
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/64995f714be48000075a544e

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +66.26 🎉

Comparison is base (0c59700) 26.42% compared to head (22f27e4) 92.68%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6062       +/-   ##
===========================================
+ Coverage   26.42%   92.68%   +66.26%     
===========================================
  Files         550      550               
  Lines       26487    26508       +21     
===========================================
+ Hits         6997    24566    +17569     
+ Misses      19490     1942    -17548     

Flag	Coverage Δ
e2e	51.61% <0.00%> (?)
integration	26.40% <0.00%> (-0.02%)	⬇️
unit	89.57% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
authentik/stages/authenticator_validate/stage.py	91.31% <100.00%> (+62.61%)	⬆️
.../stages/authenticator_validate/tests/test_stage.py	100.00% <100.00%> (+100.00%)	⬆️

... and 491 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator_validate-fix-regression-1687776866-22f27e4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator_validate-fix-regression-1687776866-22f27e4-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator_validate-fix-regression-1687776866-22f27e4

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator_validate-fix-regression-1687776866-22f27e4-arm64

Afterwards, run the upgrade commands from the latest release notes.