root: Improve multi arch Docker image build speed #7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only host architecture for GeoIP database update and for Go cross-compilation
✅ Deploy Preview for authentik-storybook canceled.
|
PKizzle
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7355 +/- ##
==========================================
+ Coverage 91.14% 92.41% +1.26%
==========================================
Files 587 587
Lines 28911 28895 -16
==========================================
+ Hits 26351 26703 +352
+ Misses 2560 2192 -368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
approved these changes
Oct 28, 2023
rissson
approved these changes
Oct 30, 2023
|
Sure, the same changes can be applied to all images that run |
|
Do you want to do it? |
|
I have updated the PR. |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think we're missing the |
|
I have changed that Dockerfile as well. |
BeryJu
approved these changes
Nov 1, 2023
|
/cherry-pick version-2023.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Improve multi arch Docker image build speed Use only host architecture for GeoIP database update and for Go cross-compilation * Speedup Go multi-arch compilation for other images * Speedup multi-arch ldap image build
BeryJu
pushed a commit
that referenced
this pull request
Nov 3, 2023
…#7426) root: Improve multi arch Docker image build speed (#7355) * Improve multi arch Docker image build speed Use only host architecture for GeoIP database update and for Go cross-compilation * Speedup Go multi-arch compilation for other images * Speedup multi-arch ldap image build Co-authored-by: Philipp Kolberg <39984529+PKizzle@users.noreply.github.com>
kensternberg-authentik
added a commit
that referenced
this pull request
Nov 3, 2023
* main: translate: Updates for file web/xliff/en.xlf in fr (#7416) website: bump react-tooltip from 5.21.6 to 5.22.0 in /website (#7412) core: bump selenium from 4.14.0 to 4.15.0 (#7411) core: bump django from 4.2.6 to 4.2.7 (#7413) web: bump the eslint group in /web with 1 update (#7414) web: bump the eslint group in /tests/wdio with 1 update (#7415) root: Improve multi arch Docker image build speed (#7355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Use only the host architecture for GeoIP database updates and for Go cross-compilation.
This significantly speeds up image creation as the GeoIP database is architecture independent and does not need to be downloaded twice. Also, cross-compilation is faster than architecture emulation.
Note: The changes in this PR are part of #7118.